Add suspicious group

[camsteffen]

changelog: Introduce clippy::suspicious 🤔 group and move several lints into the group

Closes #6366. CC #6626.

A number of lints are moved from each of correctness, style and complexity groups. Notably I didn't move suspicious_splitn since I think that is a correctness lint despite the name.

Lints moved to clippy::suspicious:

• blanket_clippy_restriction_lints (was clippy::style)
• empty_loop (was clippy::style)
• eval_order_dependence (was clippy::complexity)
• float_equality_without_abs (was clippy::correctness)
• for_loops_over_fallibles (was clippy::correctness)
• misrefactored_assign_op (was clippy::complexity)
• mut_range_bound (was clippy::complexity)
• mutable_key_type (was clippy::correctness)
• suspicious_arithmetic_impl (was clippy::correctness)
• suspicious_assignment_formatting (was clippy::style)
• suspicious_else_formatting (was clippy::style)
• suspicious_map (was clippy::complexity)
• suspicious_op_assign_impl (was clippy::correctness)
• suspicious_unary_op_formatting (was clippy::style)

[rust-highfive]

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

[flip1995]

Let's talk about this in our meeting later today, before we finalize this.

[flip1995]

r? @flip1995 (reassigning, since @giraffate takes a short break)

[xFrednet]

The changes look good to me. I focused on the addition in the metadata collection monster and that looks correct. It's nice to see that it's as simple as planned :)

[flip1995]

In today's meeting there was no veto to going forward with this. As Manish pointed out, I'll go through the Clippy RFC to see if something prevents us to do this, but we can probably do this.

[flip1995]

Reading the RFC, there's nothing preventing us from adding lint groups. Though, we can't really remove a group after adding it.

I still have to look at the lints separately.

[llogiq]

I like it! Not sure if any lints are missing from the list, but those who are there seem to be about right.

[flip1995]

Sorry for taking so long to review. The lints that were moved LGTM. One typo in the readme is left, otherwise r=me (after squashing the fixups).

[flip1995]

Oh, it would also be great, if you could edit the PR description to include from which group a lint was moved for each lint, so that writing the changelog for this will be easier :)

[camsteffen]

Added remark-gfm in order to allow the table on the readme to exceed the maximum width. See remarkjs/remark-lint#249 (comment). Needed this after updating the description of clippy::all to mention suspicious.

[camsteffen]

Oh, it would also be great, if you could edit the PR description to include from which group a lint was moved for each lint, so that writing the changelog for this will be easier :)

Done! I'll let you review one more time for the remark change.

[flip1995]

Remark changes also LGTM.

Thanks! @bors r+

[bors]

📌 Commit 5b5f0ea has been approved by flip1995

[bors]

⌛ Testing commit 5b5f0ea with merge e405c68...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing e405c68 to master...