Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use_self ICE #7428

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Fix use_self ICE #7428

merged 1 commit into from
Jul 3, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: Fix ICE #7423

r? @flip1995

@flip1995 flip1995 self-assigned this Jul 3, 2021
@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 3, 2021
@flip1995
Copy link
Member

flip1995 commented Jul 3, 2021

Thanks! Did you run this on the cxx crate / run the lintcheck tool over it? Otherwise I'll just do that.

@camsteffen
Copy link
Contributor Author

I haven't...

@flip1995
Copy link
Member

flip1995 commented Jul 3, 2021

Just ran lintcheck and this time it really passed without any suspicious errors.

@bors r+ (I will do a re-sync for this fix)

@bors
Copy link
Collaborator

bors commented Jul 3, 2021

📌 Commit cb4670d has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jul 3, 2021

⌛ Testing commit cb4670d with merge 0a59c24...

@bors
Copy link
Collaborator

bors commented Jul 3, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 0a59c24 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants