Add new lint negative_feature_names and redundant_feature_names

[Labelray]

Add new lint [negative_feature_names] to detect feature names with prefixes no- or not- and new lint [redundant_feature_names] to detect feature names with prefixes use-, with- or suffix -support
changelog: Add new lint [negative_feature_names] and [redundant_feature_names]

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

Please see the contribution instructions for more information.

[camsteffen]

There are two separate issues being linted here:

• Features beginning with no- or not- - features should be additive, the name suggests otherwise
• Features beginning with use- or with- - needless prefix

I think this should be two separate lints - negative_feature_name and feature_name_verbosity (feel free to offer other ideas). I don't think "confusing" is the right word in either case. The lint output should clearly explain what is wrong with the name.

Otherwise, this is nice, thanks!

Fixes #1746

[kangalio]

Could -support postfix be detected too? For example

[features]
embedded-graphics-support = ["embedded-graphics"]
serde-support = ["serde"]
tokio-support = ["tokio"]

Here's plenty of examples of this in the wild: https://grep.app/search?q=-support%20%3D%20%5B&filter[path.pattern][0]=Cargo.toml&filter[lang][0]=TOML

[Labelray]

Good advices! I am going to close this PR and implement two separate lints:

• [feature_name_redundancy] detecting prefix with-, use- and postfix support
• [negative_feature_name] detecting prefix not-, no-

[camsteffen]

You could, if you want, reopen and edit this PR. The two lints can have a shared implementation, just with two declare_clippy_lint!.

[Labelray]

Lints [negative_feature_name] and [redundant_feature_name] done

[camsteffen]

Empty stderr files should be removed.

[camsteffen]

There are still unresolved comments from previous reviews.

[camsteffen]

There is still an empty stderr file to be deleted.

[camsteffen]

Getting close. Thanks for your patience.

[camsteffen]

Good to go! Please squash commits.

[camsteffen]

Can you squash the first commit as well since we are not keeping the initial lint name?

[camsteffen]

Also please update the PR title and changelog in first post.

[camsteffen]

Thanks! @bors r+

[bors]

📌 Commit 0a021d5 has been approved by camsteffen

[bors]

⌛ Testing commit 0a021d5 with merge 22606e7...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 22606e7 to master...