Allow giving reasons for disallowed_methods
#7621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
azdavis
changed the title
disallowed_methods]disallowed_methods
flip1995
reviewed
Sep 2, 2021
|
☔ The latest upstream changes (presumably #7604) made this pull request unmergeable. Please resolve the merge conflicts. |
|
rebased and force-pushed to address feedback |
camsteffen
suggested changes
Sep 5, 2021
tests/ui-toml/toml_disallowed_method/conf_disallowed_method.stderr
Outdated
Show resolved
Hide resolved
camsteffen
suggested changes
Sep 7, 2021
camsteffen
approved these changes
Sep 8, 2021
|
ok, rebased and squashed into 1 commit |
|
Thanks and nice first contribution! @bors r+ |
|
📌 Commit 293db0d has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7609.
This permits writing the config for
disallowed-methodsas either a list of strings (like before) or a list of tables, where each table gives the path to the disallowed method and an optional reason for why the method is disallowed.changelog: Allow giving reasons for [
disallowed_methods]