Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make approx_const MSRV aware #7629

Merged
merged 4 commits into from Sep 5, 2021
Merged

Make approx_const MSRV aware #7629

merged 4 commits into from Sep 5, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2021

changelog: [approx_const]: Add MRSV checks for LOG10_2 and LOG2_10.

Fixes #7623

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2021
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work, your changes already look excellent. I've just found two NITs that should be addressed before merging this 🙃

clippy_lints/src/approx_const.rs Outdated Show resolved Hide resolved
clippy_lints/src/lib.rs Show resolved Hide resolved
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much for the update 🙃

@xFrednet
Copy link
Member

xFrednet commented Sep 5, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 5, 2021

📌 Commit 19d8a3e has been approved by xFrednet

@bors
Copy link
Collaborator

bors commented Sep 5, 2021

⌛ Testing commit 19d8a3e with merge d92ae50...

bors added a commit that referenced this pull request Sep 5, 2021
Make `approx_const` MSRV aware

changelog: [`approx_const`]: Add MRSV checks for LOG10_2 and LOG2_10.

Fixes #7623
@bors
Copy link
Collaborator

bors commented Sep 5, 2021

💔 Test failed - checks-action_test

@xFrednet
Copy link
Member

xFrednet commented Sep 5, 2021

@bors retry

@bors
Copy link
Collaborator

bors commented Sep 5, 2021

⌛ Testing commit 19d8a3e with merge e5ae3f5...

@bors
Copy link
Collaborator

bors commented Sep 5, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing e5ae3f5 to master...

@bors bors merged commit e5ae3f5 into rust-lang:master Sep 5, 2021
@ghost ghost deleted the fix-7623-2 branch September 6, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

approx_const not MSRV aware
3 participants