needless_borrow checks for mutable borrow
#7657
Merged
+51
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
lopopolo
reviewed
Sep 11, 2021
| LL | mut_ref(&mut &mut b); // warn | ||
| | ^^^^^^^^^^^ help: change this to: `&mut b` | ||
|
|
||
| error: this expression borrows a reference (`&i32`) that is immediately dereferenced by the compiler |
There was a problem hiding this comment.
Should this error message say &mut i32?
|
Apart from @lopopolo 's suggestion, this looks good to merge. |
dswij
force-pushed
the
needless-borrow-mut
branch
from
4fe307e
to
8938497
Compare
dswij
force-pushed
the
needless-borrow-mut
branch
from
8938497
to
81d57de
Compare
|
📌 Commit 81d57de has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7635
changelog: [
needless_borrow] now checks for needless mutable borrow