Do not expand macros in equatable_if_let suggestion #7788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
approved these changes
Oct 13, 2021
|
@bors r+ Thanks! |
|
📌 Commit 28fb591 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 13, 2021
Do not expand macros in equatable_if_let suggestion Fixes #7781 Let's use Hacktoberfest as a motivation to start contributing PRs myself again :) changelog: [`equatable_if_let`]: No longer expands macros in the suggestion
|
💔 Test failed - checks-action_test |
|
@bors retry (macOS error looks spurious) |
bors
added a commit
that referenced
this pull request
Oct 13, 2021
Do not expand macros in equatable_if_let suggestion Fixes #7781 Let's use Hacktoberfest as a motivation to start contributing PRs myself again :) changelog: [`equatable_if_let`]: No longer expands macros in the suggestion
|
💔 Test failed - checks-action_test |
|
@bors retry (windows GHA incident should be fixed now) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7781
Let's use Hacktoberfest as a motivation to start contributing PRs myself again :)
changelog: [
equatable_if_let]: No longer expands macros in the suggestion