Make useless_format recognize format!("") #7801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
aDotInTheVoid
force-pushed
the
empty-format
branch
from
24db031
to
74c2a4d
Compare
|
☔ The latest upstream changes (presumably #7853) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This is good after a rebase and remove the "add a semicolon" part - this is no longer needed after recent changes to rustc. |
aDotInTheVoid
force-pushed
the
empty-format
branch
2 times, most recently
from
720c8a6
to
b799d4a
Compare
|
Looks like we need |
aDotInTheVoid
force-pushed
the
empty-format
branch
from
b799d4a
to
081d0f8
Compare
|
@bors r+ |
|
📌 Commit 081d0f8 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7796
changelog: [
useless_format] Fix for false negitive forformat!("")