new lint: string-slice #7878
Merged
new lint: string-slice #7878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Oct 26, 2021
clippy_lints/src/strings.rs
Outdated
| /// | ||
| /// ### Known problems | ||
| /// Probably lots of false positives. If an index comes from a known valid position (e.g. | ||
| /// obtained via `char_indices` over the same string), it is totally OK. |
There was a problem hiding this comment.
nits
Suggested change
| /// obtained via `char_indices` over the same string), it is totally OK. | |
| /// obtained via `char_indices` over the same string), it is totally OK. |
giraffate
approved these changes
Oct 26, 2021
|
@bors r+ Thanks! |
|
📌 Commit 999b300 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a restriction lint to highlight code that should have tests containing non-ascii characters. See #6623.
changelog: new lint: [
string-slice]