Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advise to put a :: prefix inside the ticks #7916

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Advise to put a :: prefix inside the ticks #7916

merged 1 commit into from
Nov 2, 2021

Conversation

samueltardieu
Copy link
Contributor

Fixes #7914.

changelog: Keep an initial :: when [doc_markdown] suggests to use ticks

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 2, 2021
@samueltardieu
Copy link
Contributor Author

Asking for review by @xFrednet as they opened the original issue.

r? @xFrednet

@rust-highfive rust-highfive assigned xFrednet and unassigned giraffate Nov 2, 2021
xFrednet
xFrednet reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a quick PR 👍. The output is already looking good, but I'm a bit unsure about the documentation. I left comments on the related code segments 🙃

clippy_lints/src/doc.rs Outdated Show resolved Hide resolved
tests/ui/doc/doc.rs Outdated Show resolved Hide resolved
@samueltardieu samueltardieu force-pushed the double-colon-prefix branch 2 times, most recently from b5bbc1c to 61fd401 Compare November 2, 2021 15:55
@samueltardieu
Copy link
Contributor Author

To summarize, leading and trailing : are now included in the lint as long as there are at least two of them in a row. Single leading or trailing : are not included. Is that better?

@samueltardieu
Copy link
Contributor Author

(pushed a new version with a clearer comment)

xFrednet
xFrednet reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last tiny NIT, then it should be good to go, IMO 🙃

tests/ui/doc/doc.stderr Outdated Show resolved Hide resolved
@xFrednet
Copy link
Member

xFrednet commented Nov 2, 2021

Looks good to me, thank you for the update 👍

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 2, 2021

📌 Commit 7f8198a has been approved by xFrednet

@bors
Copy link
Collaborator

bors commented Nov 2, 2021

⌛ Testing commit 7f8198a with merge c68af43...

@bors
Copy link
Collaborator

bors commented Nov 2, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing c68af43 to master...

@bors bors merged commit c68af43 into rust-lang:master Nov 2, 2021
@bors bors mentioned this pull request Nov 2, 2021
Merged
@samueltardieu samueltardieu deleted the double-colon-prefix branch March 5, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance missing backtick detection for global identifiers doc_markdown
5 participants
@samueltardieu @rust-highfive @xFrednet @bors @giraffate