Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support suggestion for #7854 #7957

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Support suggestion for #7854 #7957

merged 1 commit into from
Nov 15, 2021

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Nov 11, 2021 •
edited
Loading

I think the detection of parking_lot's mutex and rwlock is valuable, so submit this pr, please help judge and review, thank you.

Make let_underscore_lock support parking_lot.(Fixes #7854)

changelog: Make let_underscore_lock support parking_lot

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 11, 2021
giraffate
giraffate reviewed Nov 12, 2021
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an explanation in the documentation that parking_lot is also detected?

FYI we had a little discussion about how to handle external crates:
https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/I'd.20like.20to.20hear.20opinions.20on.20clippy.237957

@surechen
Copy link
Contributor Author

Can you add an explanation in the documentation that parking_lot is also detected?

FYI we had a little discussion about how to handle external crates: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/I'd.20like.20to.20hear.20opinions.20on.20clippy.237957

Done. Thanks for your review.

giraffate
giraffate reviewed Nov 14, 2021
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Overall looks good, I made a small comment.

clippy_lints/src/let_underscore.rs Outdated Show resolved Hide resolved
@surechen
Support suggestion for rust-lang#7854
634e79c 
I think the detection of parking_lot's mutex and rwlock is valuable, so submit this pr, please help judge and review, thank you.

Make let_underscore_lock support parking_lot.

changelog: Make let_underscore_lock support parking_lot
@surechen
Copy link
Contributor Author

Sorry for the late review. Overall looks good, I made a small comment.

Done. Thanks.

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 15, 2021

📌 Commit 634e79c has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Nov 15, 2021

⌛ Testing commit 634e79c with merge f82bf47...

@bors
Copy link
Collaborator

bors commented Nov 15, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing f82bf47 to master...

@bors bors merged commit f82bf47 into rust-lang:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate approved these changes

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

let_underscore_lock does not trigger for parking_lot / non-std locks
4 participants
@surechen @rust-highfive @giraffate @bors