Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual_map with unsafe functions #7968

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Nov 13, 2021

fixes: #7820
changelog: Fix manual_map suggestion when used with unsafe functions and unsafe blocks

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 13, 2021
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adjustments look good to me! Just some small suggestions for better formatting, and then it's ready to be merged IMO 🙃

clippy_lints/src/manual_map.rs Outdated Show resolved Hide resolved
clippy_lints/src/manual_map.rs Outdated Show resolved Hide resolved
tests/ui/manual_map_option_2.rs Show resolved Hide resolved
@xFrednet
Copy link
Member

xFrednet commented Nov 17, 2021

LGTM, thank you for the fix!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 17, 2021

📌 Commit 5f861ee has been approved by xFrednet

@bors
Copy link
Collaborator

bors commented Nov 17, 2021

⌛ Testing commit 5f861ee with merge bb58dc8...

@bors
Copy link
Collaborator

bors commented Nov 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing bb58dc8 to master...

@bors bors merged commit bb58dc8 into rust-lang:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in manual_map with unsafe fn
4 participants