Fix needless_collect's tendency to suggest code requiring multiple mutable borrows of the same value.
#7982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs to generalize to other mixes of let bindings, `map` method calls, etc.
…table borrows. Also add some more tests to check that it's working.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Nov 16, 2021
1. Make the lifetime contained in LateContext `'tcx`. 2. Fix `'txc` to `'tcx` because it was a typo. 3. Refactor `IterFunctionVisitor`'s `visit_block` method to be more readable. 4. Replace uses of `rustc_middle::ty::TyKind` with `rustc::middle::ty`, and remove the `#[allow(...)]`. (Thank you llogiq for all these suggestions!)
|
I have fixed the suggestions. Thank you for making them! |
|
Thank you! @bors r+ |
|
📌 Commit c52b389 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error specified in #7975.
changelog: [
needless_collect] no longer suggests removal ofcollectwhen removal would create code requiring mutably borrowing a value multiple times.