Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more descriptive help info for needless_question_mark #8028

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

dswij
Copy link
Member

@dswij dswij commented Nov 25, 2021

closes #8016

changelog: [needless_question_mark] help suggestion now explains what should be changed

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 25, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 25, 2021

📌 Commit c0bad8b has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Nov 25, 2021

⌛ Testing commit c0bad8b with merge 35b0f24...

@bors
Copy link
Collaborator

bors commented Nov 25, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 35b0f24 to master...

@bors bors merged commit 35b0f24 into rust-lang:master Nov 25, 2021
@dswij dswij deleted the 8016 branch November 26, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more information to the error in needless_question_mark
4 participants