Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new template forms for issue templates #8032

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

flip1995
Copy link
Member

GitHub has a new way to define issue templates. This gives an even more consistent formatting of our issues.

You can find (read-only) rendered versions here. If you want to try to fill out this kind of issue, you can do this in the cargo Repo.

changelog: Better issue templates

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 25, 2021
@flip1995 flip1995 added the I-nominated Issue: Nominated to be discussed at the next Clippy meeting label Nov 25, 2021
@flip1995
Copy link
Member Author

Of course there is still the question if we want to do this. I'll bring it up in the meeting on Tuesday.

@xFrednet
Copy link
Member

Very fancy, I like this a lot! 👍

@camsteffen
Copy link
Contributor

I'd like to see error output for false positive and lint name (optional) for new lint. But that's orthogonal to using the fancy new forms, so I think this is good!

@flip1995
Copy link
Member Author

I'd like to see error output for false positive

I modified the default value of the text area. I think adding an additional section for just an error output would be overkill.

Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after squash. Thanks!

GitHub has a new way to define issue templates. This gives an even more
consistent formatting of our issues.
@flip1995 flip1995 removed the I-nominated Issue: Nominated to be discussed at the next Clippy meeting label Nov 30, 2021
@flip1995
Copy link
Member Author

Rebased+Squashed. Let's get this merged.

@bors r=camsteffen

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

📌 Commit 11002c7 has been approved by camsteffen

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

⌛ Testing commit 11002c7 with merge abaffa7...

@bors
Copy link
Collaborator

bors commented Nov 30, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing abaffa7 to master...

@bors bors merged commit abaffa7 into rust-lang:master Nov 30, 2021
@flip1995 flip1995 deleted the new_templates branch November 30, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants