Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow primitive types in disallowed_methods #8112

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Allow primitive types in disallowed_methods #8112

merged 2 commits into from
Jan 12, 2022

Conversation

Alexendoo
Copy link
Member

Fixes #8079

changelog: disallowed_methods: Now can disallow methods of primitive types

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 9, 2021
@Alexendoo Alexendoo force-pushed the disallowed_methods_primitives branch from a0de1fc to b6ecad5 Compare December 9, 2021 21:29
camsteffen
camsteffen reviewed Jan 3, 2022
View reviewed changes
clippy_utils/src/lib.rs Outdated Show resolved Hide resolved
@Alexendoo Alexendoo force-pushed the disallowed_methods_primitives branch 2 times, most recently from e88eca4 to 6e8a9a3 Compare January 3, 2022 12:48
flip1995
flip1995 reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impl LGTM. Small suggestion for an addition test.

tests/ui-toml/toml_disallowed_methods/conf_disallowed_methods.rs Show resolved Hide resolved
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jan 12, 2022
@Alexendoo
Resolve primitive impls in clippy_utils::path_to_res
91581f6
@Alexendoo
Use method name from conf::DisallowedMethod
04eb27a 
Since def_path_str returns e.g. "core::f32::<impl f32>::clamp" for
"f32::clamp"
@Alexendoo Alexendoo force-pushed the disallowed_methods_primitives branch from 6e8a9a3 to 04eb27a Compare January 12, 2022 16:23
@Alexendoo
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jan 12, 2022
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 12, 2022

📌 Commit 04eb27a has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jan 12, 2022

⌛ Testing commit 04eb27a with merge 6f33f69...

@bors
Copy link
Collaborator

bors commented Jan 12, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6f33f69 to master...

@bors bors merged commit 6f33f69 into rust-lang:master Jan 12, 2022
@Alexendoo Alexendoo deleted the disallowed_methods_primitives branch January 12, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsteffen camsteffen camsteffen left review comments

@flip1995 flip1995 flip1995 left review comments

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disallowed_method doesn't work for primitive types
6 participants
@Alexendoo @rust-highfive @flip1995 @bors @camsteffen @rustbot