Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix op_ref false positive #8298

Merged
merged 1 commit into from
Jan 18, 2022
Merged

fix op_ref false positive #8298

merged 1 commit into from
Jan 18, 2022

Conversation

ebobrow
Copy link
Contributor

@ebobrow ebobrow commented Jan 16, 2022

fixes #7572

changelog: op_ref don't lint for unnecessary reference in BinOp impl if removing the reference will lead to unconditional recursion

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 16, 2022
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 18, 2022

📌 Commit fb5f51d has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Jan 18, 2022

⌛ Testing commit fb5f51d with merge fff8e78...

@bors
Copy link
Collaborator

bors commented Jan 18, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing fff8e78 to master...

@bors bors merged commit fff8e78 into rust-lang:master Jan 18, 2022
@ebobrow ebobrow deleted the op_ref_fp branch January 18, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op_ref: Following lint leads to unconditional recursion
4 participants