Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for map_flatten on Option case #8354

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Update docs for map_flatten on Option case #8354

merged 1 commit into from
Jan 28, 2022

Conversation

dswij
Copy link
Member

@dswij dswij commented Jan 27, 2022

closes #8345

changelog: [map_flatten] Add docs info for Option case

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 27, 2022
giraffate
giraffate reviewed Jan 28, 2022
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
clippy_lints/src/methods/mod.rs Outdated Show resolved Hide resolved
@dswij dswij requested a review from giraffate January 28, 2022 04:05
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 28, 2022

📌 Commit 515ed80 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Jan 28, 2022

⌛ Testing commit 515ed80 with merge fb94992...

@bors
Copy link
Collaborator

bors commented Jan 28, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing fb94992 to master...

@bors bors merged commit fb94992 into rust-lang:master Jan 28, 2022
@dswij dswij deleted the 8345 branch January 28, 2022 05:40
@ParkMyCar
Copy link
Contributor

Thanks @dswij!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate Awaiting requested review from giraffate

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

map_flatten lint docs should include Option cases
5 participants
@dswij @rust-highfive @giraffate @bors @ParkMyCar