Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending question_mark lint for issue#8288 #8363

Closed
wants to merge 1 commit into from

Conversation

J-ZhengLi
Copy link
Member

@J-ZhengLi J-ZhengLi commented Jan 28, 2022

abandoned

to allow checking for simple `if_let` return
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 28, 2022
@J-ZhengLi
Copy link
Member Author

J-ZhengLi commented Jan 28, 2022

oops... It breaks uitest for [`manual_map_option`]

Is there a method to check for else if pattern?

@camsteffen
Copy link
Contributor

camsteffen commented Jan 28, 2022

I somehow broke my last draft PR by deleting too many commits... 🤪 so here is a new one...

You should be able to fix it with something like...

git checkout broken-branch
git reset fixed-branch --hard
git push -f

Feel free to do that and reopen the first PR.

@camsteffen
Copy link
Contributor

Oh unless they are the same branch? Maybe just git rebase master? Oh well, no big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants