[explicit_counter_loop] suggests .into_iter(), despite that triggering [into_iter_on_ref] in some cases
#8382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Feb 2, 2022
clippy_lints/src/loops/utils.rs
Outdated
| let arg_ty = cx.typeck_results().expr_ty_adjusted(arg); | ||
| match &arg_ty.kind() { | ||
| ty::Ref(_, inner_ty, mutbl) if has_iter_method(cx, inner_ty).is_some() => { | ||
| let meth_name = match mutbl { |
There was a problem hiding this comment.
nits
Suggested change
| let meth_name = match mutbl { | |
| let method_name = match mutbl { |
|
@giraffate Thank you for your code review. I have modified code. |
|
@bors r+ Thanks! |
|
📌 Commit f5fd9de has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified
fn make_iterator_snippetin clippy_lints/src/loops/utils.rs ,so this change has some little influence on another lint [manual_flatten] .fixes #8155
changelog: Fix that [
explicit_counter_loop] suggestsinto_iter()despite that triggering [into_iter_on_ref] in some cases