Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[map_identity] checks for needless map_err #8487

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Conversation

dswij
Copy link
Member

@dswij dswij commented Mar 1, 2022

Closes #8478

changelog: [map_identity] checks for needless map_err

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 1, 2022
@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Collaborator

bors commented Mar 28, 2022

📌 Commit 3d1f83e has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Mar 28, 2022

⌛ Testing commit 3d1f83e with merge 6206086...

@bors
Copy link
Collaborator

bors commented Mar 28, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 6206086 to master...

@bors bors merged commit 6206086 into rust-lang:master Mar 28, 2022
@dswij dswij deleted the 8478 branch March 28, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_identity: false negative with map_err
5 participants