Add lint to detect allow attributes without reason
#8504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
8502-allow-lint-without-reason
branch
from
b403321
to
039946e
Compare
flip1995
reviewed
Mar 4, 2022
xFrednet
force-pushed
the
8502-allow-lint-without-reason
branch
from
039946e
to
47a4ac3
Compare
xFrednet
force-pushed
the
8502-allow-lint-without-reason
branch
from
47a4ac3
to
ab6ffb6
Compare
|
Good suggestions 👍 The lint name was also something I was thinking about. I've added your suggestions and squashed the commits 🙃 |
|
@bors r+ Thanks! |
|
📌 Commit ab6ffb6 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 4, 2022
…1995 Add lint to detect `allow` attributes without reason I was considering putting this lint into the pedantic group. However, that would result in countless warnings for existing projects. Having it in restriction also seems good to me 🙃 (And now I need sleep 💤 ) --- changelog: New lint [`allow_lint_without_reason`] (Requires the `lint_reasons` feature) Closes: #8502
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was considering putting this lint into the pedantic group. However, that would result in countless warnings for existing projects. Having it in restriction also seems good to me 🙃 (And now I need sleep 💤 )
changelog: New lint [
allow_lint_without_reason] (Requires thelint_reasonsfeature)Closes: #8502