add or_then_unwrap
#8561
add or_then_unwrap
#8561
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
Welcome to the project @FoseFx 👋. I like the lint idea and the direction of your implementation is also looking good. I've added some comments with explanations and suggestions. Your welcome to reach out if anything is unclear or if you just would like some more background information 🙃
Co-authored-by: xFrednet <xFrednet@gmail.com>
There was a problem hiding this comment.
This version is already looking good. It's also nice to see that you were able to move this into the methods module. The suggestion creation is also implemented correctly. I've added four small comments, and then it can be merged. Thank you very much for the work you've done so far 🙃
|
Alright, tests are 💚. Tysm for your help! |
|
Looks good to me, thank you for your contribution. I hope you also had fun while working on this 🙃 @bors r+ |
|
📌 Commit 765cce1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #8557
changelog: New lint [
or_then_unwrap]