Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertions_on_constants: ignore indirect cfg! #8614

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Conversation

pitaj
Copy link
Contributor

@pitaj pitaj commented Apr 1, 2022

Fixes #7597

changelog: [assertions_on_constants] ignore constants indirectly based on cfg!

@rust-highfive
Copy link

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 1, 2022
@giraffate
Copy link
Contributor

r? @giraffate

@rust-highfive rust-highfive assigned giraffate and unassigned camsteffen Apr 5, 2022
clippy_utils/src/consts.rs Outdated Show resolved Hide resolved
clippy_utils/src/consts.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Can you squash the commits?

@pitaj
Copy link
Contributor Author

pitaj commented Apr 14, 2022

@giraffate squashed

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 14, 2022

📌 Commit 9f131e5 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Apr 14, 2022

⌛ Testing commit 9f131e5 with merge 80bcd9b...

@bors
Copy link
Collaborator

bors commented Apr 15, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 80bcd9b to master...

@bors bors merged commit 80bcd9b into rust-lang:master Apr 15, 2022
@pitaj pitaj deleted the fix-7597 branch April 15, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertions_on_constants incorrectly lints indirect usage of cfg!
6 participants