Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only lint mut_from_ref when unsafe code is used #8647

Merged
merged 2 commits into from Apr 13, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 6, 2022

fixes #6326

changelog: Only lint mut_from_ref when unsafe code is used.

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 6, 2022
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an explanation of why only unsafe is covered be added to What it does section?

@Jarcho
Copy link
Contributor Author

Jarcho commented Apr 8, 2022

Just rewrote the whole thing. Functions caught by this lint are not trivially unsound.

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 13, 2022

📌 Commit 1905425 has been approved by giraffate

@bors
Copy link
Collaborator

bors commented Apr 13, 2022

⌛ Testing commit 1905425 with merge 06b1695...

@bors
Copy link
Collaborator

bors commented Apr 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 06b1695 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mut_from_ref should not trigger on code which is fully safe
4 participants