Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger `[rest_pat_in_fully_bound_structs] on #[non_exhaustive]` structs #8690

Merged
merged 1 commit into from Apr 12, 2022
Merged

Do not trigger `[rest_pat_in_fully_bound_structs] on #[non_exhaustive]` structs #8690

merged 1 commit into from Apr 12, 2022

Conversation

mucinoab
Copy link
Contributor

fixes #8029

Just adds an additional check to ensure that thety::VariantDef is not marked as #[non_exhaustive].

changelog: Do not apply [`rest_pat_in_fully_bound_structs`] on structs marked as non exhaustive.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 12, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

📌 Commit 739f273 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

⌛ Testing commit 739f273 with merge 849668a...

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 849668a to master...

@bors bors merged commit 849668a into rust-lang:master Apr 12, 2022
@mucinoab mucinoab deleted the DoNot-rest_pat_in_fully_bound_structs-OnNonExhaustive branch April 12, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rest_pat_in_fully_bound_structs with #[non_exhaustive] items
4 participants