Prevent infinite (exponential) recursion in only_used_in_recursion #8691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the visitor code a bit and prevents checking expressions multiple times. I still think this lint should be removed for now, because its code isn't really tested.
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @llogiq |
flip1995
commented
Apr 12, 2022
| } | ||
|
|
||
| fn visit_expr(&mut self, ex: &'tcx Expr<'tcx>) { | ||
| if !self.visited_exprs.insert(ex.hir_id) { | ||
| return; | ||
| } | ||
| match ex.kind { | ||
| ExprKind::Array(exprs) | ExprKind::Tup(exprs) => { |
There was a problem hiding this comment.
An example for missing tests: This whole arm could be removed completely and the tests keep passing, even though this changes the semantics of the lint.
|
Thank you! That's what I would have done there, too. @bors r+ |
|
📌 Commit 214fba7 has been approved by |
That still stands. But let's talk about this on Zulip |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the visitor code a bit and prevents checking expressions
multiple times. I still think this lint should be removed for now,
because its code isn't really tested.
Fixes #8689
NOTE: Before merging this, we should talk about removing and revisiting this lint. See my comment in #8689
changelog: prevent infinite recursion in [
only_used_in_recursion]