Extend extra_unused_lifetimes to handle impl lifetimes
#8737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Apr 25, 2022
There was a problem hiding this comment.
Would these cases be false positive? I found these here:
- https://github.com/rust-lang/cargo/blob/0.49.0/src/cargo/core/source/mod.rs#L111
- https://github.com/serde-rs/serde/blob/v1.0.118/serde/src/de/mod.rs#L476
// first case
use serde::de::Visitor;
pub trait Expected {
fn fmt(&self, formatter: &mut std::fmt::Formatter);
}
impl<'de, T> Expected for T
where
T: Visitor<'de>,
{
fn fmt(&self, formatter: &mut std::fmt::Formatter) {}
}
// second case
pub trait Source {
fn hey();
}
impl<'a, T: Source + ?Sized + 'a> Source for Box<T> {
fn hey() {}
}
The answer is "yes," of course. :) I think the just pushed commit fixes the problem. |
giraffate
reviewed
Apr 25, 2022
clippy_lints/src/lifetimes.rs
Outdated
| ImplItemKind, Item, ItemKind, LangItem, Lifetime, LifetimeName, ParamName, PolyTraitRef, TraitBoundModifier, | ||
| TraitFn, TraitItem, TraitItemKind, Ty, TyKind, WhereClause, WherePredicate, | ||
| }; | ||
| use rustc_lint::{LateContext, LateLintPass}; | ||
| use rustc_middle::hir::nested_filter as mir_nested_filter; |
There was a problem hiding this comment.
I don't know why this is named mir. Can this be explained?
There was a problem hiding this comment.
I think I misread the crate name. Maybe it's better now (middle_nested_filter)?
|
@bors r+ Thanks! |
|
📌 Commit c22bb06 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6437 (cc: @carols10cents)
changelog: fix #6437