Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore redundant_pub_crate in useless_attribute #8743

Merged

Conversation

Alexendoo
Copy link
Member

changelog: [useless_attribute] no longer lints [redundant_pub_crate]

As mentioned in #8732 (comment)

And it turns out I can't even explicitly allow it at the usage site, because then clippy::useless_attribute fires (which would also be a FP?), which is deny-by-default.

Though it does work if I then allow clippy::useless_attribute. 😂

#[allow(clippy::useless_attribute)]
#[allow(clippy::redundant_pub_crate)]
pub(crate) use bit;

The originally-reported warning now no longer occurs.

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 24, 2022
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general, I only have one question.

clippy_lints/src/attrs.rs Show resolved Hide resolved
@llogiq
Copy link
Contributor

llogiq commented Apr 27, 2022

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2022

📌 Commit 0c164bb has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Apr 27, 2022

⌛ Testing commit 0c164bb with merge 18a1831...

@bors
Copy link
Collaborator

bors commented Apr 27, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 18a1831 to master...

@bors bors merged commit 18a1831 into rust-lang:master Apr 27, 2022
@Alexendoo Alexendoo deleted the useless-attribute-redundant-pub-crate branch April 27, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants