Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct ParamEnv for derive_partial_eq_without_eq #8869

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented May 22, 2022

fixes #8867

changelog: Handle differing predicates applied by #[derive(PartialEq)] and #[derive(Eq)] in derive_partial_eq_without_eq

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 22, 2022
@flip1995
Copy link
Member

flip1995 commented Jun 1, 2022

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Jun 1, 2022

📌 Commit 5cf07c6 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jun 1, 2022

⌛ Testing commit 5cf07c6 with merge 7572b6b...

@bors
Copy link
Collaborator

bors commented Jun 1, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 7572b6b to master...

@bors bors merged commit 7572b6b into rust-lang:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for derive_partial_eq_without_eq when using PhantomData
4 participants