Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce allow-dbg-in-tests config value #8897

Merged
merged 1 commit into from May 27, 2022

Conversation

tamaroning
Copy link
Contributor

@tamaroning tamaroning commented May 26, 2022

related to: Issue #8758, PR #8838

changelog: Introduced allow-dbg-in-tests config value. [dbg_macro] does not allow dbg! in test code by default.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 26, 2022
@tamaroning tamaroning marked this pull request as ready for review May 26, 2022 16:39
@tamaroning tamaroning changed the title Introduce allow-dbg-in-test config value Introduce allow-dbg-in-tests config value May 26, 2022
@xFrednet
Copy link
Member

r? @Alexendoo (If you comment something on this PR, I can also assign you to it :))

@xFrednet xFrednet self-assigned this May 26, 2022
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Manishearth
Copy link
Member

@bors r=Alexendoo

@bors
Copy link
Collaborator

bors commented May 27, 2022

📌 Commit ea06a41 has been approved by Alexendoo

@bors
Copy link
Collaborator

bors commented May 27, 2022

⌛ Testing commit ea06a41 with merge 461a661...

@bors
Copy link
Collaborator

bors commented May 27, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 461a661 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants