needless_late_init: fix ICE when all branches return the never type #8912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8911
When the assignment is done in a match guard or the if condition and all of the branches return the never type
assignment_suggestions
would return an emptyVec
which caused the ICE. It now returnsNone
in that scenarioAlso moves some tests to the top of the file
changelog: ICE Fixes: [
needless_late_init
] #8911