improve [for_loops_over_fallibles] to detect the usage of iter, iter_mut and into_iterator
#8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
…t and into_iterator
DevAccentor
force-pushed
the
for_loops_over_fallibles
branch
from
21fca07
to
5a49918
Compare
llogiq
reviewed
Jun 4, 2022
tests/ui/for_loops_over_fallibles.rs
Outdated
Comment on lines
23
to
32
| // check over a `Result` | ||
| for x in result.into_iter() { | ||
| println!("{}", x); | ||
| } | ||
|
|
||
| // check over a `Result` | ||
| for x in result.iter_mut() { | ||
| println!("{}", x); | ||
| } | ||
|
|
There was a problem hiding this comment.
I would have switched the order of those. If result wasn't Copy, this would consume it before borrowing it mutably.
|
Thanks! 👍 @bors r+ |
|
📌 Commit 3737abe has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6762
detects code like
changelog: Improve [
for_loops_over_fallibles] to detectfor _ in option.iter() {}or usingiter_mut()orinto_iterator().