List configuration values can now be extended instead of replaced #8944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
8877-append-doc-idents
branch
from
e17bcf3
to
fb9ec46
Compare
xFrednet
force-pushed
the
8877-append-doc-idents
branch
from
fb9ec46
to
c31b4a9
Compare
Manishearth
approved these changes
Jun 6, 2022
|
@bors r+ neat! |
|
📌 Commit c31b4a9 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen some
clippy.tomlfiles, that have a few additions to the default list of a configuration and then a copy of our default. The list will therefore not be updated, when we add new names. This change should make it simple for new users to append values instead of replacing them.I'm uncertain if the documentation of the
".."is apparent. Any suggestions are welcome. I've also check that the lint list displays the examples correctly.Lint list screenshots
changelog: enhancement: [
doc_markdown]: Users can now indicate, that thedoc-valid-identsshould extend the default and not replace itchangelog: enhancement: [
blacklisted-name]: Users can now indicate, that theblacklisted-namesshould extend the default and not replace itCloses: #8877
That's it. Have a fantastic weekend to everyone reading this. Here is a cookie 🍪