feat(lint): add default_iter_empty #8989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kyoto7250
force-pushed
the
default_iter_empty
branch
from
0156861
to
31ea7af
Compare
xFrednet
reviewed
Jun 14, 2022
|
☔ The latest upstream changes (presumably #8964) made this pull request unmergeable. Please resolve the merge conflicts. |
kyoto7250
force-pushed
the
default_iter_empty
branch
from
0297db5
to
3da4fa3
Compare
Alexendoo
reviewed
Jun 15, 2022
kyoto7250
force-pushed
the
default_iter_empty
branch
from
a629bb9
to
a3097e1
Compare
|
I commited your suggestion. Could I request your review? |
Alexendoo
reviewed
Jun 16, 2022
kyoto7250
force-pushed
the
default_iter_empty
branch
from
ee253ad
to
01a4ecf
Compare
|
I pushed some commits. If we need to do |
|
Yeah a squash would be good thanks |
Update description in clippy_lints/src/default_iter_empty.rs Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com> Update clippy_lints/src/default_iter_empty.rs Co-authored-by: Alex Macleod <alex@macleod.io> Update clippy_lints/src/default_iter_empty.rs Co-authored-by: Alex Macleod <alex@macleod.io> renamed default_iter_empty to default_instead_of_iter_empty Avoid duplicate messages add tests for regression rewrite 'Why is this bad?' cargo dev fmt delete default_iter_empty lint in renamed_lint.rs rewrite a message in the suggestion cargo dev update_lints --check
kyoto7250
force-pushed
the
default_iter_empty
branch
from
f01e7e5
to
2bb8c45
Compare
Alexendoo
approved these changes
Jun 17, 2022
|
Thanks! @bors r+ |
|
📌 Commit 2bb8c45 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8915
This PR adds
default_iter_emptylint.This lint checks
std::iter::Empty::default()and replace withstd::iter::empty().Thank you in advance.
changelog: add
default_instead_of_iter_emptylint.