Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std_instead_of_core, std_instead_of_alloc, alloc_instead_of_core #9103

Merged
merged 1 commit into from Jul 15, 2022

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Jul 3, 2022

Closes #7724

Introduces 3 new lints:

  • std_instead_of_core - lints items resolved through std which are available in core
  • std_instead_of_alloc - lints items resolved through std which are available in alloc
  • alloc_instead_of_core - lints items resolved through alloc which are available in core

Though the original issue only mentions std_instead_of_alloc, the other two lints could be useful as well.

questions:

  • what do I call the file the lints live in? I was thinking std_reexports?

changelog: new lint's: [std_instead_of_core], [std_instead_of_alloc], [alloc_instead_of_core]

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 3, 2022
@i509VCB i509VCB force-pushed the std-instead-of-core branch 3 times, most recently from cbbf4bb to 7070ed9 Compare July 3, 2022 02:39
@i509VCB i509VCB changed the title std_instead_of_core, std_instead_of_alloc, alloc_instead_of_core Add std_instead_of_core, std_instead_of_alloc, alloc_instead_of_core Jul 3, 2022
@bors
Copy link
Collaborator

bors commented Jul 3, 2022

☔ The latest upstream changes (presumably #9105) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just needs a rebase!

@i509VCB
Copy link
Contributor Author

i509VCB commented Jul 14, 2022

Fixed the merge conflicts

@i509VCB
Copy link
Contributor Author

i509VCB commented Jul 14, 2022

Actually sorry do not merge for a moment,

Fixed, good thing git reflog exists otherwise I almost just force pushed away the lint I wrote

@Manishearth
Copy link
Member

@bors r+

thanks!

@xFrednet
Copy link
Member

Looks like bors was sleeping. I've added a changelog entry for the new lints

@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented Jul 15, 2022

📌 Commit 2f825db has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 15, 2022

⌛ Testing commit 2f825db with merge c9f0d1a...

@xFrednet
Copy link
Member

@bors ping

@bors
Copy link
Collaborator

bors commented Jul 15, 2022

😪 I'm awake I'm awake

@bors
Copy link
Collaborator

bors commented Jul 15, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c9f0d1a to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint to identify core symbols consumed through std
5 participants