Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_without_default: ignore const generics/lifetime params on fn new #9115

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

Alexendoo
Copy link
Member

Fixes #9113

No longer lints if fn new has any params

changelog: [new_without_default]: no longer lints const generics and lifetime params on fn new

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 4, 2022
@llogiq
Copy link
Contributor

llogiq commented Jul 4, 2022

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 4, 2022

📌 Commit fec4593 has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Jul 4, 2022

⌛ Testing commit fec4593 with merge c257f09...

@bors
Copy link
Collaborator

bors commented Jul 4, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing c257f09 to master...

@bors bors merged commit c257f09 into rust-lang:master Jul 4, 2022
@Alexendoo Alexendoo deleted the new-with-const-generics branch July 4, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy's Default implementation suggestion does not take const generics into account
4 participants