-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change applicability type to MaybeIncorrect in explicit_counter_loop
#9149
Conversation
r? @Jarcho (rust-highfive has picked a reviewer for you, use r? to override) |
applicability, | ||
|diag| { | ||
diag.span_suggestion( | ||
expr.span.with_hi(arg.span.hi()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done once before the span_lint
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commited 134d0de
Thank you. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
close #9013
This PR changes applicability type to
MaybeIncorrect
, because the suggestion is notMachineApplicable
.changelog: change applicability type to MaybeIncorrect in
explicit_counter_loop