Extend if_then_some_else_none to also suggest bool::then_some

[mkrasnitski]

Closes #9094.

changelog: Extend if_then_some_else_none to also suggest bool::then_some

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information.

[xFrednet]

Looks good to me. As a suggestion, could you mention bool:then_some in the lint description? The current example suggests bool::then which could/should be bool::then_some. As another change, you could just mention bool::then_some in the "Why is this bad?" section. Something like:

For simple calculation and known values you can also use bool::then_some which is eagerly avaluated in comparison to bool:then.

Otherwise, this is ready to merge. 👍 Thank you for the contribution and patience 🙃

[mkrasnitski]

Thanks for the review! I've pushed some changes to the lint's description.

[xFrednet]

Perfect, thank you for the implementation and quick follow up. I hope you had fun while working on Clippy 🙃

@bors r+

[bors]

📌 Commit f7f60b8 has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit f7f60b8 with merge 05fc1c7...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 05fc1c7 to master...