Fix [non_ascii_literal] in tests
#9327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Serial-ATA
force-pushed
the
non_ascii_literal_macro
branch
from
207a19a
to
8d130fb
Compare
|
Tests storing their contents as a literal sounds rather odd, I'm gonna try and find out what the purpose of that is/if it can be removed |
Alexendoo
reviewed
Aug 13, 2022
Serial-ATA
force-pushed
the
non_ascii_literal_macro
branch
from
8d130fb
to
bd121ef
Compare
Alexendoo
approved these changes
Aug 16, 2022
|
Great, thanks! Thanks also for trying the early lint path even though it didn't pan out @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Don't lint [
non_ascii_literal] when using non-ascii comments in testschangelog: Don't lint [
non_ascii_literal] whenallowed on testscloses: #7739
closes: #8263