[Arithmetic] Consider literals

[c410-f3r]

Fixes #9307 and makes the arithmetic lint behave like integer_arithmetic.

It is worth noting that literal integers of a binary operation (1 + 1, i32::MAX + 1), regardless if they are in a constant environment, won't trigger the lint. Assign operations also have similar reasoning.

changelog: Consider literals in the arithmetic lint

[rust-highfive]

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

[c410-f3r]

Just to show that arithmetic behaves like integer_arithmetic and float_arithemtic. Once approved, I will revert this line.

[Alexendoo]

👍

Just a couple small bits to suggest

[c410-f3r]

Addressed all comments with a new strategy and additional tests

[Alexendoo]

Nice, thanks!

I think it'd be worth updating the lint documentation to mention that the lint doesn't fire for cases where overflow can't happen

[c410-f3r]

Nice, thanks!

I think it'd be worth updating the lint documentation to mention that the lint doesn't fire for cases where overflow can't happen

Done

[Alexendoo]

Thanks!

@bors r+

Renaming the lint may be a good idea yeah. Could ask on zulip for some input on a potential name, my vote would probably be the slight variation arithmetic_side_effects

[bors]

📌 Commit 0d078c9 has been approved by Alexendoo

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0d078c9 with merge 617417e...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 617417e to master...