Fix mut_mutex_lock
when Mutex is behind immutable deref
#9418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the problem here is the
if let ty::Ref(_, _, Mutability::Mut) = cx.typeck_results().expr_ty(recv).kind()
line tries to check if theMutex
can be mutably borrowed (there already is a test forArc<Mutex<_>>
), but gets bamboozled by the&mut Arc
indirection. And I think checking the deref-adjustment to filter immutable-adjust (the deref through theArc
, starting from&mut Arc
) is the correct fix.Fixes #9415
changelog: Fix
mut_mutex_lock
when Mutex is behind immutable deref