Make derivable_impls machine applicable
#9429
Conversation
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
tests/ui/derivable_impls.stderr
Outdated
| = help: Remove it | ||
| help: and instead derive it | ||
| | | ||
| LL | #[derive(Default)] | ||
| | |
There was a problem hiding this comment.
Since the Span is 0-length long, the struct XXX part is not shown. I don't think this is a big issue now that it can be fixed automatically, but didn't find how to fix it in case it's a deal breaker.
|
This version looks good to me, but you need to bless the test one more time, after fixing the typo 🙃 |
|
Thank you, I don't know for sure the commit policy on the repo (squash everything in the end/no force push during review/...) so haven't cleaned the history (yet if needed) |
|
We have a no merge commit policy. For the number of commits and squashing, we often go by feel. If the commits are structured well with good message or just one fix commit, we usually just merge it as it is. In this case, it would be cool, if you could squash them into one or two commits. A small thing about squashing a rebasing is that GitHub doesn't work too well with it. So, after the first review, it's typically better to wait until the end for a rebase if you want to. You can of course also ask the reviewer. With small adjustments like this one, I often squash the change directly to the last commit and force push. In short, we don't have a set in stone policy ^^. It would be cool if you could clean up the history, and then we can merge it 🙃 |
|
Perfect, this looks good to me! Thank you very much for this addition and the swift responses. 🙃 @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: [
derivable_impls]: Now machine applicable