Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expand macro in nonminimal_bool suggestions #9457

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

kraktus
Copy link
Contributor

@kraktus kraktus commented Sep 10, 2022

fix #9428

changelog: Do not expand macros in [nonminimal_bool] suggestions

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 10, 2022
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 10, 2022

📌 Commit d50f366 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 10, 2022

⌛ Testing commit d50f366 with merge c8c2a23...

@bors
Copy link
Collaborator

bors commented Sep 10, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c8c2a23 to master...

@bors bors merged commit c8c2a23 into rust-lang:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nonminimal_bool suggestion is inaccurate for macros
4 participants