Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unnecessary_cast] add parenthesis when negative number uses a method #9577

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

kraktus
Copy link
Contributor

@kraktus kraktus commented Oct 2, 2022

fix #9563

The issue was probably introduced by 90fe3be

changelog: [unnecessary_cast] add parenthesis when negative number uses a method

r? llogiq

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 2, 2022
@kraktus
Copy link
Contributor Author

kraktus commented Oct 2, 2022

I can never do it right first time 😅

r? @llogiq

@rust-highfive rust-highfive assigned llogiq and unassigned flip1995 Oct 2, 2022
@llogiq
Copy link
Contributor

llogiq commented Oct 2, 2022

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 2, 2022

📌 Commit 90b446f has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 2, 2022

⌛ Testing commit 90b446f with merge ac12011...

@bors
Copy link
Collaborator

bors commented Oct 2, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing ac12011 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Oct 2, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing ac12011 to master...

@bors bors merged commit ac12011 into rust-lang:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in code behavior/values from linting (-8.0 as f64).exp() -> -8.0_f64.exp()
5 participants