Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix box-default ignoring trait objects' types #9622

Merged
merged 1 commit into from Oct 23, 2022

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Oct 10, 2022

This avoids removing the turbofish when the Box type is a dyn or impl _.

This fixes #9621.


changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 10, 2022
@llogiq
Copy link
Contributor Author

llogiq commented Oct 23, 2022

Philipp seems a bit busy.

r? @Alexendoo

@rust-highfive rust-highfive assigned Alexendoo and unassigned flip1995 Oct 23, 2022
@Alexendoo
Copy link
Member

Nice and simple 👍

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 23, 2022

📌 Commit bd61fdb has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 23, 2022

⌛ Testing commit bd61fdb with merge 4f142aa...

@bors
Copy link
Collaborator

bors commented Oct 23, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4f142aa to master...

@bors bors merged commit 4f142aa into rust-lang:master Oct 23, 2022
@llogiq llogiq deleted the box-dyn-default branch October 24, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

box-default wrongly suggest on dyn trait
5 participants