Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result_large_err show largest variants in err msg #9662

Merged
merged 1 commit into from Nov 11, 2022

Conversation

ebobrow
Copy link
Contributor

@ebobrow ebobrow commented Oct 16, 2022

fixes #9538

changelog: Sugg: [result_large_err]: Now show largest enum variants in error message

@rust-highfive
Copy link

r? @dswij

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 16, 2022
@bors
Copy link
Collaborator

bors commented Nov 7, 2022

☔ The latest upstream changes (presumably #8744) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@dswij
Copy link
Member

dswij commented Nov 11, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 11, 2022

📌 Commit 80e5856 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 11, 2022

⌛ Testing commit 80e5856 with merge cad0d3d...

@bors
Copy link
Collaborator

bors commented Nov 11, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing cad0d3d to master...

@bors bors merged commit cad0d3d into rust-lang:master Nov 11, 2022
@ebobrow ebobrow deleted the result-large-err branch November 11, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

result_large_err include largest enum variant
4 participants