-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move needless_collect to nursery #9705
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. |
cc @rust-lang/clippy we probably can write up a plan for what it would take to enable it again |
(fwiw the typical procedure is to open an issue first and list prior issues and discussions, but this works too) |
For the tests failing in CI, should these tests be skipped by default, or is there another procedure for them? |
You'll need to run |
@Jarcho - I ran |
With #9541 lint re-categorizing got really simple it seems. Doesn't even require @jntrnr The
There are many issues open for this lint with a pretty detailed description of some significant FPs. I would say the plan to enable this lint again would be to fix those first. Some of them will be quite hard though, because they will involve predicting borrowing rules... |
Didn't notice that one. Yay for less merge conflicts. |
@flip1995 - thanks, that fixed. |
Yeah I'm basically thinking we file an issue listing all the existing bugs, and also saying the general area of things that ought to be explored for further bugs before un-nurserying it. |
I favor of this move, the lint produces some FPs in another project of mine as well :) |
Everyone seems on board, I'm merging @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: [
needless_collect
]: Moveneedless_collect
to nursery (Now allow-by-default)After chatting with a few folks, it seems like
needless_collect
is giving false positives pretty regularly (https://github.com/rust-lang/rust-clippy/issues?q=is%3Aissue+is%3Aopen+needless_collect). We're big supporters of clippy in Nushell, and it's one of the passes we require for CI, but we've had to disable this particular lint. Perhaps it should be moved to the nursery until it's improved?(apologies if this isn't the right approach to disabling a lint by default. I tried to follow the idea I saw other PRs doing in the past)