Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track clippy.toml and Cargo.toml in file_depinfo #9707

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Alexendoo
Copy link
Member

Causes cargo to re-run clippy when those paths are modified

Also tracks the path to clippy-driver in debug mode to remove the workarounds in cargo dev lint and lintcheck (cc @matthiaskrgr)

changelog: Automatically re-run Clippy if Cargo.toml or clippy.toml are modified

Fixes #2130
Fixes #8512

r? @flip1995

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 24, 2022
@Alexendoo Alexendoo force-pushed the file-depinfo branch 2 times, most recently from 468ba1e to c07ab80 Compare October 24, 2022 21:10
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question. r=me if the tempfile dep cannot be removed.

clippy_dev/src/lint.rs Show resolved Hide resolved
Causes cargo to re-run clippy when those paths are modified

Also tracks the path to `clippy-driver` in debug mode to remove the
workarounds in `cargo dev lint` and `lintcheck`
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 25, 2022

📌 Commit bd83690 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 25, 2022

⌛ Testing commit bd83690 with merge 5e29870...

@bors
Copy link
Collaborator

bors commented Oct 25, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 5e29870 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Cargo.toml file doesn't change the lint Re-run after modifying config file
4 participants