Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bool_to_int_with_if] do not lint in const context #9738

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

kraktus
Copy link
Contributor

@kraktus kraktus commented Oct 28, 2022

changelog: [bool_to_int_with_if] do not lint in const context

fix #9737

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 28, 2022
@xFrednet
Copy link
Member

Looks good to me, thank you for the update 🙃

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

📌 Commit fa6850d has been approved by xFrednet

It is now in the queue for this repository.

bors added a commit that referenced this pull request Oct 29, 2022
[`bool_to_int_with_if`] do not lint in const context

changelog: [`bool_to_int_with_if`] do not lint in const context

fix #9737
@bors
Copy link
Collaborator

bors commented Oct 29, 2022

⌛ Testing commit fa6850d with merge 1441158...

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 1441158 to master...

@xFrednet
Copy link
Member

xFrednet commented Oct 29, 2022

Thanks, bors would you mind merging it, when it succeeded? And some say bots will take over the world. JK

@bors retry

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

⌛ Testing commit fa6850d with merge 8e19251...

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 8e19251 to master...

@bors bors merged commit 8e19251 into rust-lang:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bool_to_int_with_if triggers in const contexts
4 participants